Microsoft.media new version 2020 05 01#9889
Merged
allenjzhang merged 12 commits intoAzure:masterfrom Jun 24, 2020
giakas:Microsoft.Media-New-Version-2020-05-01
Merged
Microsoft.media new version 2020 05 01#9889allenjzhang merged 12 commits intoAzure:masterfrom giakas:Microsoft.Media-New-Version-2020-05-01
allenjzhang merged 12 commits intoAzure:masterfrom
giakas:Microsoft.Media-New-Version-2020-05-01
Conversation
[Staging] Swagger Validation Report
️✔️ |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-js - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Contributor
|
Can one of the admins verify this patch? |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ties of a PATCH request body must not be required. PATCH operation: 'LiveEvents_Update' Model Definition: 'TrackedResource' Property: 'location'"
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…omplaining about duplicate
|
Azure Pipelines successfully started running 1 pipeline(s). |
allenjzhang
reviewed
Jun 24, 2020
| "created": "0001-01-01T00:00:00Z", | ||
| "lastModified": "0001-01-01T00:00:00Z", | ||
| "vanityUrl": false, | ||
| "useStaticHostname": false, |
Contributor
There was a problem hiding this comment.
any particular reason to change the property name? This would cause SDK breaking change across versions.
allenjzhang
approved these changes
Jun 24, 2020
Contributor
|
Hi @ravbhatnagar, here is case for lint Rule 2016(patchbodyparametersschema) which new added, as @giakas changed ref TrackedResource to common types.json which 'location' is required , so it caused lint R2016 failure in patch operation. looks @giakas can not put discriminator as document guide. Do you have any suggestion for this? currently the Lint failure has been suppressed. |
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Adds base for updating Microsoft.Media from version stable/2018-07-01 to version 2020-05-01 * Updates readme * Updates API version in new specs and examples * Updating the some swagger files to new version. * Update to latest swaggers and fix some examples. * fix prettier issue * fix some linter issues * fix spell check. * Add a supression for R2016 linter rule, which was failing for "Properties of a PATCH request body must not be required. PATCH operation: 'LiveEvents_Update' Model Definition: 'TrackedResource' Property: 'location'" * Fix a validation error * add 204 for the delete account. * Move ApiError and ODataError to a different file, as autorest v3 is complaining about duplicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.